update test to cover other cases